Pass encoding into readFile

Thinkmill · Aug 9, 2024 · 7bffb28 · 7bffb28
1 parent 3cf3ecb
commit 7bffb28
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 9 deletions.
diff --git a/packages/tools/src/expandPackageGlobs.ts b/packages/tools/src/expandPackageGlobs.ts
@@ -27,20 +27,19 @@ export async function expandPackageGlobs(
   const discoveredPackages: Array<Package | undefined> = await Promise.all(
     directories.map((dir) =>
       fsp
-        .readFile(path.join(dir, "package.json"))
+        .readFile(path.join(dir, "package.json"), "utf-8")
         .catch((err) => {
           if (err && (err as { code: string }).code === "ENOENT") {
             return undefined;
           }
           throw err;
         })
-        .then((result: Buffer | undefined) => {
-          const s = result?.toString();
-          if (s) {
+        .then((result) => {
+          if (result) {
             return {
               dir: path.resolve(dir),
               relativeDir: path.relative(directory, dir),
-              packageJson: JSON.parse(s),
+              packageJson: JSON.parse(result),
             };
           }
         })

diff --git a/packages/tools/src/utils.ts b/packages/tools/src/utils.ts
@@ -3,9 +3,11 @@ import fsp from "fs/promises";
 import path from "path";
 
 export const readJson = async (directory: string, file: string) => JSON.parse((await fsp.readFile(
-    path.join(directory, file)
-  )).toString());
+    path.join(directory, file),
+    "utf-8"
+  )));
 
 export const readJsonSync = (directory: string, file: string) => JSON.parse(fs.readFileSync(
-    path.join(directory, file)
-  ).toString());
+    path.join(directory, file),
+    "utf-8"
+  ));