Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert unnecessary change to babel config #234

Merged

Conversation

VanTanev
Copy link
Contributor

Turns out, @Andarist was correct in #231 (comment) - because babel was updated, this setting is not needed.

Copy link

changeset-bot bot commented Oct 17, 2024

⚠️ No Changeset found

Latest commit: df660d8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Andarist
Copy link
Collaborator

Hm, when was Babel updated though? 😅 I don't see any recent upgrades - so I wonder: why you have observed broken behavior before and why the change turned out to be unnecessary now?

@VanTanev
Copy link
Contributor Author

VanTanev commented Oct 17, 2024

My guess is that my local node_modules got into a bad state somehow? I cannot replicate the error I was getting before 😭

I thought that the upgrade of @preconstruct/cli might have been the fix after all, but that's not the case, because it works fine even without it.

@Andarist Andarist merged commit 7e61ad6 into Thinkmill:main Oct 17, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants