Skip to content

Commit

Permalink
[twitter] Add support for unified cards (closes ytdl-org#27826)
Browse files Browse the repository at this point in the history
  • Loading branch information
dstftw authored and ThirumalaiK committed Jan 28, 2021
1 parent 754b525 commit c3a24b7
Showing 1 changed file with 26 additions and 2 deletions.
28 changes: 26 additions & 2 deletions youtube_dl/extractor/twitter.py
Original file line number Diff line number Diff line change
Expand Up @@ -373,6 +373,24 @@ class TwitterIE(TwitterBaseIE):
'uploader_id': '1eVjYOLGkGrQL',
},
'add_ie': ['TwitterBroadcast'],
}, {
# unified card
'url': 'https://twitter.com/BrooklynNets/status/1349794411333394432?s=20',
'info_dict': {
'id': '1349794411333394432',
'ext': 'mp4',
'title': 'md5:d1c4941658e4caaa6cb579260d85dcba',
'thumbnail': r're:^https?://.*\.jpg',
'description': 'md5:71ead15ec44cee55071547d6447c6a3e',
'uploader': 'Brooklyn Nets',
'uploader_id': 'BrooklynNets',
'duration': 324.484,
'timestamp': 1610651040,
'upload_date': '20210114',
},
'params': {
'skip_download': True,
},
}, {
# Twitch Clip Embed
'url': 'https://twitter.com/GunB1g/status/1163218564784017422',
Expand Down Expand Up @@ -433,8 +451,7 @@ def _real_extract(self, url):
'tags': tags,
}

media = try_get(status, lambda x: x['extended_entities']['media'][0])
if media and media.get('type') != 'photo':
def extract_from_video_info(media):
video_info = media.get('video_info') or {}

formats = []
Expand All @@ -461,6 +478,10 @@ def add_thumbnail(name, size):
'thumbnails': thumbnails,
'duration': float_or_none(video_info.get('duration_millis'), 1000),
})

media = try_get(status, lambda x: x['extended_entities']['media'][0])
if media and media.get('type') != 'photo':
extract_from_video_info(media)
else:
card = status.get('card')
if card:
Expand Down Expand Up @@ -493,6 +514,9 @@ def get_binding_value(k):
'_type': 'url',
'url': get_binding_value('card_url'),
})
elif card_name == 'unified_card':
media_entities = self._parse_json(get_binding_value('unified_card'), twid)['media_entities']
extract_from_video_info(next(iter(media_entities.values())))
# amplify, promo_video_website, promo_video_convo, appplayer, ...
else:
is_amplify = card_name == 'amplify'
Expand Down

0 comments on commit c3a24b7

Please sign in to comment.