-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix compilation error on Loong64. #54
Conversation
Signed-off-by: liuxiang <liuxiang@loongson.cn>
Alternative solution to #54
Alternative solution to #54 Really this should be checking that the path name is empty, too, because the first arg is `dirfd`, and so this filter is based on: ``` By file descriptor If pathname is an empty string and the AT_EMPTY_PATH flag is speci‐ fied in flags (see below), then the target file is the one referred to by the file descriptor dirfd. ```
Thanks for the PR. Could you try the alternate fix I implemented in 99b5445 ? |
Yes,it is worked
…-----原始邮件-----
发件人:"Thomas Habets" ***@***.***>
发送时间:2024-01-15 22:19:19 (星期一)
收件人: ThomasHabets/arping ***@***.***>
抄送: liuxiang88 ***@***.***>, Author ***@***.***>
主题: Re: [ThomasHabets/arping] Fix compilation error on Loong64. (PR #54)
Could you try the alternate fix I implemented in 99b5445 ?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Thanks for confirming! |
Same issue on ARMv6 (Raspberry Pi 1).
99b5445 gets it past that hurdle, but now it's dying on |
@whitslack could you please try adding But sigh, yeah seccomp really does suck. I'll continue to claim that there's no way to use it correctly, until someone proves otherwise. |
Yes, that gets it working.
That is my opinion as well. I have had to contribute patches to other projects using seccomp to add missing syscalls to them as well. The principal issue is that standard library functions do not specify which syscalls they will invoke, so there is actually no conformant way to compute the set of needed syscalls for a given set of standard library function calls. By the way, I'm not sure that your " |
It only tries to compile & link, not run. But yes, it does assume that the kernel will be happy with constants sent to it by a userspace that only existed on a different machine. I guess it assumes a "similar enough" kernel version, which may not be true. |
@whitslack have you found this to be a problem with default settings? Unless you give I don't think I'll ever be able to default to |
Gentoo's
|
@ThomasHabets: Why do you test for existence of syscalls at compile time? That can break if you run on a different kernel than you compile on. Shouldn't you unconditionally |
@whitslack that sounds quite reasonable. Thanks for the pointer. I'll get on that. |
In case the build system is too different from the target system. Bug #54
@whitslack that's now done. Thanks again. |
The system call statx is used instead of stat, lstat and fstat on LoongArch64.