Improve typings and fix snackbar close callback #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
June 27, 2024 14:36
There was a problem hiding this comment.
Hi, thanks for PR, and sorry for late !
Nice work, I let you add Level type on index.d.ts for CreateNotifyOptions !
I don't really understand why you added onCloseSnackbar prop to Snackbar.vue, because when snackbar closes, the Promise is closed too, so you can do whatever you want in .then() of it ?
|
@ThomasLeconte Hi Thomas, you are right! I have reverted the callback, it should not be necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: adding types/node for the package.json to fix the npm install
fix: inform the TypeScript compiler about the existence of the global
fix: fix types of the level & fix onCloseSnackbar callback of SnackBar component