Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Improved Snackbar stacking and placement when a dialog is shown #25

Merged
merged 1 commit into from
Sep 6, 2024

Conversation

Shaxine
Copy link
Contributor

@Shaxine Shaxine commented Sep 1, 2024

This PR fixes the snackbar stacking logic when multiple snackbars from different locations (e.g. "top right", "bottom left") are shown. It also fixes the placement of the snackbars when a dialog is shown at the same time.

@Shaxine
Copy link
Contributor Author

Shaxine commented Sep 5, 2024

@ThomasLeconte to clarify, this PR fixes the following bugs:

  1. Snackbar stacking logic when multiple snackbars from different locations (e.g. top right, bottom left) are shown:

    • Before fix:
      Captura de ecrã de 2024-09-05 16-13-19

    • After fix:
      Captura de ecrã de 2024-09-05 16-16-42

  2. Placement of the snackbars when a dialog is shown at the same time:

    • Before fix:
      Captura de ecrã de 2024-09-05 16-14-01

    • After fix:
      Captura de ecrã de 2024-09-05 16-16-51

Let me know if you need anything else.

@ThomasLeconte
Copy link
Owner

Oh my bad ! I thought it was a lib component but it's a test component 😅 Ok, nice work ! I will tell you when next release is available 😉

@ThomasLeconte ThomasLeconte merged commit d0552f9 into ThomasLeconte:master Sep 6, 2024
@ThomasLeconte
Copy link
Owner

@Shaxine v1.5.2 is available !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants