Merge remote-tracking branch 'origin/feature/document_upload_without_…

…title' into thuenen_4.x

geonode/documents/api/serializers.py

@@ -19,6 +19,7 @@
 import logging
 
 from dynamic_rest.fields.fields import DynamicComputedField
+from rest_framework import serializers
 from geonode.base.api.serializers import ResourceBaseSerializer
 from geonode.documents.models import Document
 
@@ -39,6 +40,7 @@ class DocumentSerializer(ResourceBaseSerializer):
     def __init__(self, *args, **kwargs):
         # Instantiate the superclass normally
         super().__init__(*args, **kwargs)
+        self.fields["title"] = serializers.CharField(required=False)
 
     file_path = GeonodeFilePathField(required=False)
     doc_file = DocumentFieldField(required=False)

geonode/documents/api/tests.py

@@ -45,6 +45,7 @@ def setUp(self):
         self.url = reverse("documents-list")
         self.invalid_file_path = f"{settings.PROJECT_ROOT}/tests/data/thesaurus.rdf"
         self.valid_file_path = f"{settings.PROJECT_ROOT}/base/fixtures/test_xml.xml"
+        self.no_title_file_path = f"{settings.PROJECT_ROOT}/base/fixtures/test_sld.sld"
 
     def test_documents(self):
         """
@@ -143,6 +144,18 @@ def test_creation_should_create_the_doc(self):
         self.assertEqual("xml", extension)
         self.assertTrue(Document.objects.filter(title="New document for testing").exists())
 
+    def test_uploading_doc_without_title(self):
+        """
+        A document should be uploaded without specifying a title
+        """
+        self.client.force_login(self.admin)
+        payload = {"document": {"metadata_only": True, "file_path": self.no_title_file_path}}
+        actual = self.client.post(self.url, data=payload, format="json")
+        self.assertEqual(201, actual.status_code)
+        extension = actual.json().get("document", {}).get("extension", "")
+        self.assertEqual("sld", extension)
+        self.assertTrue(Document.objects.filter(title="test_sld.sld").exists())
+
     def test_patch_point_of_contact(self):
         document = Document.objects.first()
         url = urljoin(f"{reverse('documents-list')}/", f"{document.id}")

geonode/documents/models.py

@@ -80,7 +80,8 @@ def compact_permission_labels(cls):
     @property
     def name(self):
         if not self.title:
-            return str(self.id)
+            if len(self.files) > 0:
+                return self.files[0].split("/")[-1]
         else:
             return self.title