Obsolete the remaining public APIs of the TileDB.Interop namespace. (…

…#347)

Four enums were forgotten to be deprecated in #278. This PR deprecates them and they will be made internal in the 5.10.x cycle.

docs/obsoletions.md

@@ -8,6 +8,7 @@ Following [the deprecation policy of TileDB Embedded][core-deprecation], obsolet
 |----------------|---------------------|------------------|
 |[`TILEDB0001`](#TILEDB0001) …[`TILEDB0011`](#TILEDB0011)|5.3.0|5.5.0|
 |[`TILEDB0012`](#TILEDB0012) …[`TILEDB0013`](#TILEDB0013)|5.7.0|5.9.0|
+|[`TILEDB0012`](#TILEDB0014) …[`TILEDB0013`](#TILEDB0014)|5.8.0|5.10.0|
 
 ## `TILEDB0001` - Enum value names that start with `TILEDB_` were replaced with C#-friendly names.
 
@@ -319,8 +320,6 @@ The obsoleted APIs fall into the following categories:
 - The types that derive from `SafeHandle` are used to safely manage the lifetime of native TileDB objects. With the APIs in the `TileDB.CSharp` namespace providing broad coverage of TileDB's functionalities while also being safer and easier to sue, these types provide limited utility. You should use the APIs in the `TileDB.CSharp` namespace instead.
 - Types with the name `tiledb_***_t` were made public again only to support the APIs of the safe handles above. They have little other use on their own. You should use APIs in the `TileDB.CSharp` namespace instead.
 
-[core-deprecation]: https://github.com/TileDB-Inc/TileDB/blob/dev/doc/policy/api_changes.md
-
 ## `TILEDB0013` - The `EnumUtils.TypeToDataType` and `EnumUtils.DataTypeToType` methods are obsolete and will be removed in a future version.
 
 <a name="TILEDB0013"></a>
@@ -334,3 +333,19 @@ The `EnumUtils.TypeToDataType` and `EnumUtils.DataTypeToType` methods convert be
 ### Recommended action
 
 If you are performing queries on arrays of unknown schema, you can use the `Query.UnsafeSetDataBuffer` and `Query.UnsafeSetWriteDataBuffer` methods to set a data buffer to a query without type validation.
+
+## `TILEDB0014` - Members of the `TileDB.Interop` namespace will become internal in a future version and should not be used by user code.
+
+<a name="TILEDB0014"></a>
+
+Some APIs in the `TileDB.Interop` namespace that were inadvertently removed in version 5.3.0 were reintroduced in version 5.7.0. They are marked as obsolete in version 5.8.0 and hidden from IntelliSense and will be removed from the public API for good in version 5.10.0. They were also reintroduced in patch releases 5.3.1 and 5.4.1, obsoleted under the [`TILEDB0003`](#TILEDB0003) code.
+
+### Version introduced
+
+5.8.0
+
+### Recommended action
+
+Stop using the obsoleted APIs. No other public API of `TileDB.CSharp` depends on them.
+
+[core-deprecation]: https://github.com/TileDB-Inc/TileDB/blob/dev/doc/policy/api_changes.md

sources/TileDB.CSharp/Interop/tiledb_array_type_t.cs

@@ -1,7 +1,13 @@
 // <auto-generated/>
 
+using System;
+using System.ComponentModel;
+using TileDB.CSharp;
+
 namespace TileDB.Interop
 {
+    [Obsolete(Obsoletions.TileDBInterop3Message, DiagnosticId = Obsoletions.TileDBInterop3DiagId, UrlFormat = Obsoletions.SharedUrlFormat)]
+    [EditorBrowsable(EditorBrowsableState.Never)]
     public enum tiledb_array_type_t
     {
         TILEDB_DENSE = 0,

sources/TileDB.CSharp/Interop/tiledb_datatype_t.cs

@@ -1,7 +1,13 @@
 // <auto-generated/>
 
+using System;
+using System.ComponentModel;
+using TileDB.CSharp;
+
 namespace TileDB.Interop
 {
+    [Obsolete(Obsoletions.TileDBInterop3Message, DiagnosticId = Obsoletions.TileDBInterop3DiagId, UrlFormat = Obsoletions.SharedUrlFormat)]
+    [EditorBrowsable(EditorBrowsableState.Never)]
     public enum tiledb_datatype_t
     {
         TILEDB_INT32 = 0,

sources/TileDB.CSharp/Interop/tiledb_filter_type_t.cs

@@ -1,7 +1,13 @@
 // <auto-generated/>
 
+using System;
+using System.ComponentModel;
+using TileDB.CSharp;
+
 namespace TileDB.Interop
 {
+    [Obsolete(Obsoletions.TileDBInterop3Message, DiagnosticId = Obsoletions.TileDBInterop3DiagId, UrlFormat = Obsoletions.SharedUrlFormat)]
+    [EditorBrowsable(EditorBrowsableState.Never)]
     public enum tiledb_filter_type_t
     {
         TILEDB_FILTER_NONE = 0,

sources/TileDB.CSharp/Interop/tiledb_query_type_t.cs

@@ -1,7 +1,13 @@
 // <auto-generated/>
 
+using System;
+using System.ComponentModel;
+using TileDB.CSharp;
+
 namespace TileDB.Interop
 {
+    [Obsolete(Obsoletions.TileDBInterop3Message, DiagnosticId = Obsoletions.TileDBInterop3DiagId, UrlFormat = Obsoletions.SharedUrlFormat)]
+    [EditorBrowsable(EditorBrowsableState.Never)]
     public enum tiledb_query_type_t
     {
         TILEDB_READ = 0,

sources/TileDB.CSharp/Obsoletions.cs

@@ -44,5 +44,8 @@ internal static class Obsoletions
 
         public const string DataTypeTypeConversionsMessage = "The EnumUtils.TypeToDataType and EnumUtils.DataTypeToType methods are obsolete and will be removed in a future version.";
         public const string DataTypeTypeConversionsDiagId = "TILEDB0013";
+
+        public const string TileDBInterop3Message = "Members of the TileDB.Interop namespace should not be used by user code and will become internal in a future version.";
+        public const string TileDBInterop3DiagId = "TILEDB0014";
     }
 }

sources/TileDB.CSharp/TileDB.CSharp.csproj

@@ -12,7 +12,7 @@
     <GenerateDocumentationFile>true</GenerateDocumentationFile>
     <EnablePackageValidation>true</EnablePackageValidation>
     <PackageValidationBaselineVersion>5.6.0</PackageValidationBaselineVersion>
-    <NoWarn>$(NoWarn);TILEDB0012;TILEDB0013</NoWarn>
+    <NoWarn>$(NoWarn);TILEDB0012;TILEDB0013;TILEDB0014</NoWarn>
   </PropertyGroup>
 
   <ItemGroup>