-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert floating the Core's version in tests and fix CI. #417
Conversation
Fixes nightly builds.
.NET 5 does not support macOS in Apple Silicon.
Any objections in just skipping building the examples on macOS? There are complications with GitHub Actions switching The risk is low: the examples do not contain any platform-specific code and they will still run on Ubuntu and Windows. Other things we can do:
@ihnorton thoughts? |
This seems preferable. |
CI is green. I have launched a nightly build on my fork. Once it succeeds, I will merge this and make a release. |
Nightlies are successful. Merging… |
Fixes nightly builds.
For some backstory, the packaging system of the C# API enables Core patches to be released without any changes to the C# API package. This has the downside that by default the earliest (
.0
) Core patch gets used, which means that to update the Core users have to install theTileDB.Native
package themselves.c3f0ace tried to make the tests always use the latest Core version, but it caused nightlies to fail because we cannot install floating versions of packages because we have enabled NuGet Central Package Management. This PR reverts that commit. The
.0
patch will still get used, and I left instructions in the tests for how to run tests with a subsequent patch version. Core patches still get tested in nightly builds, by building the Core from therelease-*
branch.