Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert floating the Core's version in tests and fix CI. #417

Merged
merged 5 commits into from
Apr 30, 2024

Conversation

teo-tsirpanis
Copy link
Member

Fixes nightly builds.

For some backstory, the packaging system of the C# API enables Core patches to be released without any changes to the C# API package. This has the downside that by default the earliest (.0) Core patch gets used, which means that to update the Core users have to install the TileDB.Native package themselves.

c3f0ace tried to make the tests always use the latest Core version, but it caused nightlies to fail because we cannot install floating versions of packages because we have enabled NuGet Central Package Management. This PR reverts that commit. The .0 patch will still get used, and I left instructions in the tests for how to run tests with a subsequent patch version. Core patches still get tested in nightly builds, by building the Core from the release-* branch.

.NET 5 does not support macOS in Apple Silicon.
@teo-tsirpanis
Copy link
Member Author

Any objections in just skipping building the examples on macOS? There are complications with GitHub Actions switching macos-latest to Apple Silicon and .NET 5 not supporting it. If I build the examples just for .NET 6 they still are built for .NET 5 for some reason and preventing this is not trivial, with some early attempts of mine failing. I have no idea why the tests succeed at the same time.

The risk is low: the examples do not contain any platform-specific code and they will still run on Ubuntu and Windows.

Other things we can do:

  • Stop targeting .NET 5 in the examples – the tests will still run in both .NET 5 and 6
  • Roll back CI images macos-12 – I prefer not to since it would introduce more technical debt in the future, and coverage on ARM64 is always a good thing.

@ihnorton thoughts?

@ihnorton
Copy link
Member

Stop targeting .NET 5 in the examples – the tests will still run in both .NET 5 and 6

This seems preferable.

@teo-tsirpanis
Copy link
Member Author

CI is green. I have launched a nightly build on my fork. Once it succeeds, I will merge this and make a release.

@teo-tsirpanis
Copy link
Member Author

Nightlies are successful. Merging…

@teo-tsirpanis teo-tsirpanis merged commit d3ce456 into TileDB-Inc:main Apr 30, 2024
4 checks passed
@teo-tsirpanis teo-tsirpanis deleted the fix-nightly branch April 30, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment