Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Core to 2.24. #433

Merged
merged 8 commits into from
Jun 14, 2024
Merged

Conversation

teo-tsirpanis
Copy link
Member

No description provided.

@teo-tsirpanis teo-tsirpanis marked this pull request as ready for review June 14, 2024 12:47
{
var context = Context.GetDefault();

using var uri = new TemporaryDirectory("array_upgrade_version");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think it will be upgraded 😬 aside from S3 or committing the array though I'm not sure how we could test it with an array from a previous format version. Any ideas?

https://github.com/TileDB-Inc/TileDB/blob/93220d7c3041fcd05fdbf8a45cc9969f47aaf763/tiledb/sm/array/array.cc#L2161

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed, this test only calls the function to check that nothing catastrophic happened. We could check in an empty array with an older format version (just the schema file would be tiny), but I am slightly to moderately against this.

The Python API is doing something interesting. 👀

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh nice find! The format version is the first field in the array schema on disk.. Could we create an array and then adjust the first 4 bytes to set an older version?

https://github.com/TileDB-Inc/TileDB/blob/dev/format_spec/array_schema.md#array-schema-file

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can't do that easily because the schema is compressed, and it would be very fragile either way.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the test.

@teo-tsirpanis teo-tsirpanis merged commit 40a7cc2 into TileDB-Inc:main Jun 14, 2024
4 checks passed
@teo-tsirpanis teo-tsirpanis deleted the update-2.24 branch June 14, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants