Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin to Python 3.7.16 on Mac OS due to GitHub Actions breakage. #429

Closed
wants to merge 2 commits into from

Conversation

thetorpedodog
Copy link
Contributor

Due to this issue:
actions/setup-python#682
Python 3.7 does not work on Mac OS. Instead we manually seed the matrix with the right Python version for each OS.

ihnorton
ihnorton previously approved these changes Jun 27, 2023
Copy link
Member

@ihnorton ihnorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (when green). Thanks!

Due to this issue:
actions/setup-python#682
Python 3.7 does not work on Mac OS. Instead we store a point release
in an environment variable and install that.
@thetorpedodog thetorpedodog dismissed ihnorton’s stale review June 30, 2023 16:17

New strategy to set the correct version on Mac OS.

@thetorpedodog
Copy link
Contributor Author

Re-requesting a review because I reworked how we pick what version to install.

@thetorpedodog
Copy link
Contributor Author

cool how it shows that i pushed the branch but does not seem to be updating the view here

@thetorpedodog
Copy link
Contributor Author

finally got github to pick up that a change was made. failures are unrelated (and extremely confusing).

@thetorpedodog
Copy link
Contributor Author

Actually this has been obsoleted! Apparently GitHub pushed a working version of 3.7.17.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants