Wrap tiledb_handle_load_array_schema_request. #329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaunrd0
requested review from
NullHypothesis,
ypatia,
snagles and
thetorpedodog
as code owners
serialize.go
Outdated
| @@ -514,6 +514,23 @@ func DeserializeQueryAndArray(context *Context, buffer *Buffer, serializationTyp | |||
| return array, query, nil | |||
| } | |||
|
|
|||
| // HandleLoadArraySchemaRequest Pass the array and serialized request to core which returns the serialized response. | |||
There was a problem hiding this comment.
Could this be made more descriptive? Most functions in this package pass something to core, so that doesn’t really illuminate much.
serialize.go
Outdated
| @@ -514,6 +514,23 @@ func DeserializeQueryAndArray(context *Context, buffer *Buffer, serializationTyp | |||
| return array, query, nil | |||
| } | |||
|
|
|||
| // HandleLoadArraySchemaRequest Pass the array and serialized request to core which returns the serialized response. | |||
| func HandleLoadArraySchemaRequest(array *Array, serializationType SerializationType, request *Buffer) (*Buffer, error) { | |||
There was a problem hiding this comment.
Looking at a few of our functions above, most of them seem to put the request in front of the serialization type in the parameter list.
thetorpedodog
approved these changes
Jul 16, 2024
serialize.go
Outdated
| } | ||
|
|
||
| runtime.KeepAlive(request) | ||
| runtime.KeepAlive(response) |
There was a problem hiding this comment.
This really isn't necessary, since the buffer is returned, but isn't harmful either.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This wraps tiledb_handle_load_array_schema_request added in TileDB-Inc/TileDB#4399. This binding is required for https://github.com/TileDB-Inc/TileDB-Cloud-REST/pull/4686.