Update Go versions to test. #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NullHypothesis
requested review from
ypatia,
shaunrd0,
snagles and
thetorpedodog
as code owners
snagles
approved these changes
Jul 24, 2024
|
If we’re doing this, perhaps we should update the |
We need to be sure that the latest minor release works well.
NullHypothesis
force-pushed
the
phw/update-go-versions-2
branch
from
2537a92
to
c00b828
Compare
On second thought, I think it's best to add 1.22 to the test array while keeping 1.20 in go.mod. After all, we're not using any new language features, so there's no strong reason to update. |
thetorpedodog
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should include the latest minor release (1.22) and I see no harm in discontinuing testing with 1.20.
This PR is identical to #326 but I couldn't merge it because there are two now-obsolete jobs that are stuck, so I'm opening a new PR.