Make various improvements to our GitHub workflow #347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are no significant downsides to using the latest version for both Ubuntu and macOS runners.
Go 1.23 was released last month. Time to test it!
These latest versions may (or may not) benefit us and they certainly shouldn't harm us.
NullHypothesis
force-pushed
the
phw/improve-github-workflow
branch
from
aed6e0e
to
fca85fe
Compare
Ever since v4, `actions/setup-go` can cache dependencies as long as `actions/checkout` is run first, which we do: https://github.com/actions/setup-go#v4
NullHypothesis
force-pushed
the
phw/improve-github-workflow
branch
2 times, most recently
from
6f2ba78
to
1a070d8
Compare
NullHypothesis
requested review from
ypatia,
shaunrd0,
snagles and
thetorpedodog
as code owners
snagles
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular:
I recommend reviewing the PR commit by commit.