Skip to content

Commit

Permalink
Fix syntax error in nightly build workflow (#1970)
Browse files Browse the repository at this point in the history
* Fix syntax error in nightly build workflow

* Update test for TileDB-Inc/TileDB#4973
  • Loading branch information
ihnorton authored May 17, 2024
1 parent 3abea77 commit 9430e9a
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/daily-test-build-numpy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ jobs:
TILEDB_VERSION: ${{ github.event.inputs.libtiledb_version }}
# 11.7 necessary due to: https://github.com/actions/setup-python/issues/682#issuecomment-1604261330
#MACOSX_DEPLOYMENT_TARGET: "10.15"
MACOSX_DEPLOYMENT_TARGET: ${{ matrix.os == 'macos-12' && matrix.python-version == '3.8' ? '11.7' : '11' }}
MACOSX_DEPLOYMENT_TARGET: ${{ matrix.os == 'macos-12' && matrix.python-version == '3.8' && '11.7' || '11' }}
VCPKG_BINARY_SOURCES: 'clear;x-gha,readwrite'
steps:
- name: Checkout TileDB-Py `dev`
Expand Down
7 changes: 5 additions & 2 deletions tiledb/tests/cc/test_cc.py
Original file line number Diff line number Diff line change
Expand Up @@ -275,8 +275,11 @@ def test_schema():

with pytest.raises(lt.TileDBError):
schema._tile_order = lt.LayoutType.HILBERT
schema._tile_order = lt.LayoutType.UNORDERED
assert schema._tile_order == lt.LayoutType.UNORDERED
if tiledb.libtiledb.version() >= (2, 24, 0):
with pytest.raises(lt.TileDBError):
schema._tile_order = lt.LayoutType.UNORDERED
schema._tile_order = lt.LayoutType.ROW_MAJOR
assert schema._tile_order == lt.LayoutType.ROW_MAJOR

# TODO schema._set_coords_filter_list(...)
# TODO assert schema._coords_filter_list() == lt.FilterListType.NONE
Expand Down

0 comments on commit 9430e9a

Please sign in to comment.