-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce longterm environment to TSI resource hierarchy #7
Conversation
Fix R2016 by making PATCH body properties optional. Suppress the remaining 4 violations that are confirmed as false positives.
@ravbhatnagar |
@@ -1201,12 +1202,56 @@ | |||
], | |||
"description": "The sku determines the capacity of the environment, the SLA (in queries-per-minute and total capacity), and the billing rate." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also determines the "storage type" now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated the description to indicate the Sku determines the type of environment.
…heritance from TrackedResource.
Got email signoff from @ravbhatnagar |
Add a new L1 Sku for long-term environments. Introduces a new "kind" property on Environment that is used as a discriminator to determine whether the environment is "Standard" or "LongTerm". This is basically the same pattern as we use when creating event sources.
Changes are on a new preview api version. This api is initially hidden behind a feature flag for private preview of long-term environments.
Review by ARM team is being added on the pull-request into the TimeSeriesInsights fork so we can get signoff early rather than wait until it goes to master.
This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.
PR information
api-version
in the path should match theapi-version
in the spec).Quality of Swagger