Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce longterm environment to TSI resource hierarchy #7

Merged
merged 10 commits into from
Sep 11, 2018

Conversation

sandshadow
Copy link

Add a new L1 Sku for long-term environments. Introduces a new "kind" property on Environment that is used as a discriminator to determine whether the environment is "Standard" or "LongTerm". This is basically the same pattern as we use when creating event sources.

Changes are on a new preview api version. This api is initially hidden behind a feature flag for private preview of long-term environments.

Review by ARM team is being added on the pull-request into the TimeSeriesInsights fork so we can get signoff early rather than wait until it goes to master.

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@sandshadow sandshadow requested a review from yeskarthik August 21, 2018 18:14
@sandshadow
Copy link
Author

@ravbhatnagar
Can you review this change to the TSI swagger spec? It's a PR into the team's fork of the repository so we can get the ARM team's review before we are ready to expose publicly.

@@ -1201,12 +1202,56 @@
],
"description": "The sku determines the capacity of the environment, the SLA (in queries-per-minute and total capacity), and the billing rate."

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also determines the "storage type" now?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the description to indicate the Sku determines the type of environment.

@sandshadow
Copy link
Author

Got email signoff from @ravbhatnagar

@sandshadow sandshadow merged commit 2a64ead into TimeSeriesInsights:master Sep 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants