Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor/81] 공부 분류/방법/장소에 isDefault 추가 #87

Merged
merged 6 commits into from
Aug 20, 2024

Conversation

Eunjin3395
Copy link
Contributor

@Eunjin3395 Eunjin3395 commented Aug 19, 2024

🚀 개요

공부 분류/방법/장소에 isDefault 추가

🔍 변경사항

  • dto, converter에 isDefault 추가
  • StudyType, StudyMethod, StudyPlace 엔티티에 isDefault 추가
  • StudyType, StudyMethod, StudyPlace 수정 API Endpoint 변경 (POST -> PATCH)
  • StudyType, StudyMethod, StudyPlace 수정 API에 isDefault 여부 변경 로직 추가

⏳ 작업 내용

  • StudyType, StudyMethod, StudyPlace 엔티티에 isDefault 추가
  • StudyType, StudyMethod, StudyPlace 수정 API Endpoint 변경
  • StudyType, StudyMethod, StudyPlace 수정 API에 isDefault 여부 변경 로직 추가

📝 논의사항

Copy link
Contributor

@BaekJaehyuk BaekJaehyuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다 : )

// 활성화된 공부 분류와의 이름 중복 여부 검증
boolean exists = studyTypeRepository.existsByMemberAndTitleAndStatus(member,
request.getTitle(), CategoryStatus.ACTIVE);
if (exists) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

추후에 if문 안에 if문 리팩토링하면 좋을 듯 싶습니다.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

넵! 전체적인 기능 구현 완료 후에 리팩토링 해보겠습니다 !!

@Eunjin3395 Eunjin3395 merged commit b7d05b9 into develop Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

♻️ [Refactor] 공부 분류/방법/장소 조회 및 수정 API에 default 여부 추가
2 participants