-
-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Manifest file #31
Conversation
Thanks! Do you need me to do a release to PyPI? |
The only file that should be mentioned there is |
@Tinche a release would be great! Thank You! |
@Tinche please ping me here conda-forge/staged-recipes#4192 after the release |
recursive-include aiofiles *.py | ||
|
||
include README.rst | ||
include MANIFEST.in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for a comment after merging but MANIFEST.in
is not needed in the file.
Maybe it doesn't make a harm but no other project has the line IMHO.
I'm pretty sure aio-libs: aiohttp, yarl, multidict and others works pretty well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
MANIFEST.in, MANIFEST and setup.py don’t need to be in MANIFEST.in, indeed.
@@ -0,0 +1,6 @@ | |||
recursive-include aiofiles *.py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The line should be removed: setuptools/distutils has a rule to include all .py
files from mentioned packages.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is true.
Uh, it works like it is now, so I'm not in a rush to fix it. If someone wants to submit a cleanup PR, I'll be happy to merge it in :) |
see conda-forge/staged-recipes#4192