Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting output_user_root affects hashes #198

Closed
kusaeva opened this issue Dec 22, 2023 · 1 comment
Closed

Setting output_user_root affects hashes #198

kusaeva opened this issue Dec 22, 2023 · 1 comment

Comments

@kusaeva
Copy link

kusaeva commented Dec 22, 2023

Hello!
We start using in our .bazelrc startup --output_user_root=/tmp-XXX and suddenly notice that this option affects hashes produced by bazel-diff.
I have already seen this comment about using --ignoredRuleHashingAttributes and tried running bazel-diff with --ignoredRuleHashingAttributes=location,path. But unfortunately it still produces different hashes for different output_user_root dirs.
How to figure out what attributes to add in this option to make bazel-diff's results consistent?
Thank you for any help!

@kusaeva
Copy link
Author

kusaeva commented Dec 25, 2023

Suddenly I realized this option expects space-separated attributes.
Tried `--ignoredRuleHashingAttributes="location path", it works.

IMHO it will be better to have consistent style for options FYI @tinder-maxwellelliott

@kusaeva kusaeva closed this as completed Dec 25, 2023
tinder-maxwellelliott added a commit that referenced this issue Feb 3, 2024
This should use comma separated values

Related #198 (comment)
tinder-maxwellelliott added a commit that referenced this issue Feb 3, 2024
This should use comma separated values

Related #198 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant