Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix more canonical names #231

Merged
merged 1 commit into from
Oct 2, 2024

Conversation

honnix
Copy link
Contributor

@honnix honnix commented Oct 1, 2024

This is a continuation of #224 to fix more places canonical names might be used.

There are things like @<repo>//...:all-targets, which I think should work for both cases as well.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@honnix honnix marked this pull request as ready for review October 2, 2024 06:46
@honnix
Copy link
Contributor Author

honnix commented Oct 2, 2024

@tinder-maxwellelliott Please take a look and let me know what you think. Thanks.

@tinder-maxwellelliott tinder-maxwellelliott merged commit ba464a4 into Tinder:master Oct 2, 2024
8 checks passed
@honnix honnix deleted the more-on-bzlmod branch October 2, 2024 11:44
@honnix
Copy link
Contributor Author

honnix commented Oct 2, 2024

@tinder-maxwellelliott Thank you for merging. When do you think is possible to cut a new release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants