Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make token and repository params optional #47

Merged
merged 4 commits into from
Jul 10, 2024
Merged

Make token and repository params optional #47

merged 4 commits into from
Jul 10, 2024

Conversation

piotrekkr
Copy link
Contributor

@piotrekkr piotrekkr commented Jul 5, 2024

In majority of use cases of this action, it is working on current workflow run repository and use default GH actions token. Would be nice if those parameters were optional and taken from github context by default.

piotrekkr added 3 commits July 5, 2024 13:40
In majority of use cases of this action it is working on current workflow run repository and use same default GH actions token. Would be nice if those parameters were optional and taken from github context by default.
@piotrekkr piotrekkr marked this pull request as ready for review July 5, 2024 11:57
@Tiryoh
Copy link
Owner

Tiryoh commented Jul 10, 2024

Hi @piotrekkr, thanks for your PR!

Could you update .github/workflows/test.yaml to test without github_token: ${{ secrets.GITHUB_TOKEN }}?

@piotrekkr
Copy link
Contributor Author

piotrekkr commented Jul 10, 2024

Hi @piotrekkr, thanks for your PR!

Could you update .github/workflows/test.yaml to test without github_token: ${{ secrets.GITHUB_TOKEN }}?

@Tiryoh Done in 7bad79d (#47). Does this look okay?

@Tiryoh
Copy link
Owner

Tiryoh commented Jul 10, 2024

@piotrekkr Great! Thanks!

@Tiryoh Tiryoh merged commit 6e2eaa1 into Tiryoh:main Jul 10, 2024
4 checks passed
@piotrekkr piotrekkr deleted the patch-1 branch July 10, 2024 12:09
@Tiryoh Tiryoh mentioned this pull request Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants