-
Notifications
You must be signed in to change notification settings - Fork 679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace join_chat boolean with chat: ChatPresence #253
Conversation
…ALWAYS, NEVER, ONLINE (ONLY), OFFLINE (ONLY)
As it is this is a breaking change no ? (non-breaking is currently checked) |
uhm yes could break all the configurations files 🤔 we could maintain a backward compatibility with the |
Edit: Marked as Breaking change |
¿Does this branch currently work? I am interested in giving it a try. |
@Yishaqel yup |
When I try to make it work I also get the error 'Error pagination' so I guess it is not up to date. |
Please try now :) |
Now it works, I will be in this branch checking that everything works as it should. |
any news? :) |
Description
Allowed values for
chat
are:ALWAYS
Join in IRC chat and never leaveNEVER
Never join IRC chatONLINE
Partecipate to IRC chat if the streamer is online (leave if offline)OFFLINE
Partecipate to IRC chat if the streamer is offline (leave if online)Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.
Checklist: