Replace join_chat boolean with chat: ChatPresence

[Tkd-Alex]

Description

Allowed values for chat are:

• ALWAYS Join in IRC chat and never leave
• NEVER Never join IRC chat
• ONLINE Partecipate to IRC chat if the streamer is online (leave if offline)
• OFFLINE Partecipate to IRC chat if the streamer is offline (leave if online)

Fixes # (issue)

Type of change

Please delete options that are not relevant.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality not to work as expected)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration.

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my code
• I have commented on my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation (README.md)
• My changes generate no new warnings
• Any dependent changes have been updated in requirements.txt

[Rakambda]

As it is this is a breaking change no ? (non-breaking is currently checked)
join_chat=True of previous configurations will break when this is merged.

[Tkd-Alex]

uhm yes could break all the configurations files 🤔 we could maintain a backward compatibility with the join_chat=True as ChatPresence.online

[Tkd-Alex]

Edit: Marked as Breaking change

[Yishaqel]

¿Does this branch currently work? I am interested in giving it a try.

[Tkd-Alex]

@Yishaqel yup

[Yishaqel]

@Yishaqel yup

When I try to make it work I also get the error 'Error pagination' so I guess it is not up to date.

[Tkd-Alex]

@Yishaqel yup

When I try to make it work I also get the error 'Error pagination' so I guess it is not up to date.

Please try now :)

[Yishaqel]

@Yishaqel yup

When I try to make it work I also get the error 'Error pagination' so I guess it is not up to date.

Please try now :)

Now it works, I will be in this branch checking that everything works as it should.

[Tkd-Alex]

@Yishaqel yup

When I try to make it work I also get the error 'Error pagination' so I guess it is not up to date.

Please try now :)

Now it works, I will be in this branch checking that everything works as it should.

any news? :)