Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added docker support #300

Closed
wants to merge 3 commits into from
Closed

Added docker support #300

wants to merge 3 commits into from

Conversation

KamushekDev
Copy link

@KamushekDev KamushekDev commented Oct 4, 2021

Description

This adds the ability to run miner as a docker container

Fixes #79 (not really)

Type of change

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

I've performed the whole process from cloning to starting the miner inside docker c:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented on my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (README.md)
  • My changes generate no new warnings
  • Any dependent changes have been updated in requirements.txt

@1v
Copy link
Contributor

1v commented Oct 14, 2021

There is error:

  gcc -pthread -Wno-unused-result -Wsign-compare -DNDEBUG -g -fwrapv -O3 -Wall -fPIC -Ilz4libs -I/usr/local/include/python3.10 -c lz4/_version.c -o build/temp.linux-x86_64-3.10/lz4/_version.o -O3 -Wall -Wundef
  error: command 'gcc' failed: No such file or directory
  ----------------------------------------
  ERROR: Failed building wheel for lz4

@Tkd-Alex Tkd-Alex added the enhancement New feature or request label Oct 28, 2021
Dockerfile Outdated
@@ -0,0 +1,7 @@
FROM python:slim
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to use the python one here, except if you are going to install gcc manually. Otherwise it will throw an error.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed that

Dockerfile Outdated
COPY requirements.txt .
RUN pip install -r requirements.txt
COPY . .
ENTRYPOINT ["python3", "main.py"]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be run.py as described in the readme

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeap

@Tkd-Alex Tkd-Alex closed this Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker Support
4 participants