Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add name keyword argument to fiona.open() and Collection constructor #1351

Closed
sgillies opened this issue Mar 9, 2024 · 2 comments · Fixed by #1352
Closed

Add name keyword argument to fiona.open() and Collection constructor #1351

sgillies opened this issue Mar 9, 2024 · 2 comments · Fixed by #1352
Assignees
@sgillies
Labels
enhancement
Milestone
1.10

Comments

@sgillies
Copy link
Member

sgillies commented Mar 9, 2024

And pass it through to GDALDatasetCreateLayer().

See also #1348.
@sgillies sgillies added this to the 1.10 milestone Mar 9, 2024
@sgillies sgillies self-assigned this Mar 9, 2024
@sgillies
Copy link
Member Author

sgillies commented Mar 9, 2024

Now that I think about it more, name is reserved for the filename/URI given to the constructor. The layer keyword, which already exists, is the thing to rely on.

@nk9
Copy link

nk9 commented Mar 9, 2024 •
edited
Loading

Yes, layer is certainly what I initially expected to work! Thanks for opening this, looking foward to being able to use it.

sgillies added a commit that referenced this issue Mar 11, 2024
@sgillies
Allow a GeoJSON collection's name to be set in write mode
636da70 
Resolves #1351
@sgillies sgillies mentioned this issue Mar 11, 2024
Merged
sgillies added a commit that referenced this issue Mar 11, 2024
@sgillies
Allow a GeoJSON collection's name to be set in write mode (#1352)
3d48234 
* Allow a GeoJSON collection's name to be set in write mode

Resolves #1351

* Update change log entry

* Remove commented code

* Add coding directive to test file

* Skip a test on Windows
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgillies sgillies

Labels
enhancement
Projects
None yet
Milestone
1.10
Development

Successfully merging a pull request may close this issue.

Allow a GeoJSON collection's name to be set in write mode Toblerity/Fiona
2 participants
@sgillies @nk9