-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/admin dashboard visualize group events 413 #448
Feature/admin dashboard visualize group events 413 #448
Conversation
- The admin dashboard now renders recurring events (with a groupId) as a single item on the admin dashboard
…ure/adminDashboardVisualizeGroupEvents-413
…ure/adminDashboardVisualizeGroupEvents-413
When the DataService fails to retrieve the displayName for the user, "UNKNOWN" is displayed in its place.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious why this was added. Did we not have this functionality?
Otherwise, LGTM
Before, repeating events were rendered individually for each instance. |
Sorry I was referencing a code block that didn't carry over to the comment. I'm surprised we did not have the functionality referenced below in
|
Not that I could find. There were only Cypress commands for |
Description
Group repeating events with the same
groupId
into a single items on the admin dashboard and split single (non-repeating) events and repeating events into separate sections.Type of change
Please select everything applicable. Please, do not delete any lines.
Issue
This PR addresses issue #413
Checklist:
npm run test
and all tests have passed successfully or I have included details within my PR on the failure.npm run lint
and resolved any outstanding errors. Most issues can be solved by executingnpm run format