Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump JDA version to 324 #31

Merged
merged 1 commit into from
Sep 8, 2021
Merged

Bump JDA version to 324 #31

merged 1 commit into from
Sep 8, 2021

Conversation

Tais993
Copy link
Member

@Tais993 Tais993 commented Sep 8, 2021

Updates JDA (they forgot something with slash-commands, has been added now)

Updates JDA (they forgot something with slash-commands, has been added now)
@java-coding-prodigy
Copy link
Contributor

Its kinda weird how it would be faster for the owner to do the commit and push the minor change themselves rather than someone creating a PR.

@Tais993
Copy link
Member Author

Tais993 commented Sep 8, 2021

Its kinda weird how it would be faster for the owner to do the commit and push the minor change themselves rather than someone creating a PR.

This way everything stays controlled

@Zabuzard
Copy link
Member

Zabuzard commented Sep 8, 2021

Its kinda weird how it would be faster for the owner to do the commit and push the minor change themselves rather than someone creating a PR.

This is not wild west. Any change has to be reviewed by at least 2 people from the members of this organization (Staff Helpers + Moderators).

That said, reviewed. Ready for merge.

@Tais993 Tais993 merged commit 7cef713 into Together-Java:develop Sep 8, 2021
Tais993 added a commit that referenced this pull request Sep 8, 2021
* Bump JDA version to 324 (#31)

Updates JDA (they forgot something with slash-commands, has been added now)

* Add spotless integration

This hopefully makes formatting more consistent. The Eclipse XML style
was chosen as it is understood by Eclipse, VSC (JDT), Spotless and
mostly by IntelliJ.

* Make gradelew executable

* Add "Remove unused imports" setting to spotless

Co-authored-by: Marko Radosavljević <marko@radosavljevic.dev>

* Remove unused imports to fix diffplug/spotless#834 (#35)

Co-authored-by: I-Al-Istannen <i-al-istannen@users.noreply.github.com>
Co-authored-by: Marko Radosavljević <marko@radosavljevic.dev>
Co-authored-by: Jonas <jnhrd254@gmail.com>
@Tais993 Tais993 mentioned this pull request Sep 8, 2021
@Zabuzard Zabuzard added the enhancement New feature or request label Sep 9, 2021
@Zabuzard Zabuzard added this to the Initial Setup milestone Sep 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants