Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Slope Sculpting Tool #96

Closed
TokisanGames opened this issue Jul 1, 2023 · 8 comments · Fixed by #297
Closed

Implement Slope Sculpting Tool #96

TokisanGames opened this issue Jul 1, 2023 · 8 comments · Fixed by #297
Labels
enhancement New feature or request
Milestone

Comments

@TokisanGames
Copy link
Owner

TokisanGames commented Jul 1, 2023

This issue is for sculpting a slope. This should be a tool. For painting textures by slope, see #282

Brush Slope does nothing and was hidden in 283767e, merged in #91.

Implement it.

@TokisanGames TokisanGames added the bug Something isn't working label Jul 1, 2023
@TokisanGames TokisanGames added this to the Minimum Viable Product milestone Jul 1, 2023
@TokisanGames TokisanGames changed the title Brush slope does nothing Implement Brush Slope Jul 1, 2023
@TokisanGames TokisanGames added enhancement New feature or request low priority Low Priority and removed bug Something isn't working labels Jul 1, 2023
@tcoxon
Copy link
Contributor

tcoxon commented Dec 7, 2023

It's looking like I'll need this tool for my project. Do you have a particular idea in mind for how it would work? If our needs align, I could consider implementing & contributing it.

Something like the flatten tool, where you pick a starting height, then click and drag, with the difference being the further you drag from your starting point, the lower the height gets, according to an angle setting?

@TokisanGames
Copy link
Owner Author

TokisanGames commented Dec 7, 2023

I'll take PRs for slope sculpting. I'm thinking: Select starting point, Select ending point, and it automatically creates a grade between them in the general shape and size of the current brush.

Starting/ending elevations can be predefined with the other brushes.

I've found when brushing heights that I need a slope to connect between a higher area and a lower area. I don't think I've ever needed an arbitrary length brush. Have you found differently? Where you want to start making a grade without a destination in mind?

@tcoxon
Copy link
Contributor

tcoxon commented Dec 7, 2023

Have you found differently? Where you want to start making a grade without a destination in mind?

We're only just in the process of initially blocking out terrain. In our case, the destination doesn't matter too much because almost all space is unused. And it can be useful to guarantee a particular angle to the slope to ensure navigability. But I can see that if you've already got a lot of stuff on your terrain that you want to keep, it makes sense to need a particular end point.

Do you see slope height brush as being:

  1. Drag from starting point to ending point. Then when you release the mouse button, it modifies the terrain with a slope between them in a straight line from start to end.
  2. Or click starting point, click ending point, then click and drag out a potentially wavy line between the two, modifying terrain as the mouse moves?

@TokisanGames
Copy link
Owner Author

What I envision is a simple: Click start, click end, straight slope is created. No drag.

However, if you want to do # 2, click start, click end, then it becomes drawable with height auto adjusting depending on proximity to start or ending points, also using opacity. That's an interesting option.

Why don't you do both? Have a drawable checkbox. If it's not checked we get the instant straight slope. If checked it is drawable.

@tcoxon
Copy link
Contributor

tcoxon commented Dec 7, 2023

What would opacity do here?

@TokisanGames
Copy link
Owner Author

Try the height brush with low opacity and you'll see it fills in more gradually than when it is 100%.

@TokisanGames TokisanGames changed the title Implement Brush Slope Implement Slope Sculpting Tool Dec 19, 2023
@TokisanGames TokisanGames removed the low priority Low Priority label Dec 19, 2023
@TokisanGames
Copy link
Owner Author

TokisanGames commented Dec 19, 2023

I have split sculpting a slope from slope painting into two separate issues. Let's keep the discussion on sculpting a slope here. Painting based on slope has been moved to #282.

Repository owner deleted a comment from niceandgoodonline Dec 19, 2023
tcoxon added a commit to tcoxon/Terrain3D that referenced this issue Jan 9, 2024
tcoxon added a commit to tcoxon/Terrain3D that referenced this issue Jan 9, 2024
tcoxon added a commit to tcoxon/Terrain3D that referenced this issue Jan 22, 2024
TokisanGames pushed a commit to tcoxon/Terrain3D that referenced this issue Jan 25, 2024
TokisanGames pushed a commit that referenced this issue Jan 25, 2024
@TokisanGames TokisanGames modified the milestones: 1.0, 0.9.1 Jan 25, 2024
@TokisanGames
Copy link
Owner Author

Fixed by #297

@TokisanGames TokisanGames modified the milestones: 0.9.1, Beta 0.9.x Feb 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants