control map api changes #494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xtarsia
force-pushed
the
control-map-api_changes
branch
from
f90e4c2
to
2ab1bf6
Compare
Xtarsia
force-pushed
the
control-map-api_changes
branch
from
2ab1bf6
to
4120131
Compare
TokisanGames
reviewed
Oct 2, 2024
TokisanGames
reviewed
Oct 2, 2024
TokisanGames
reviewed
Oct 2, 2024
TokisanGames
reviewed
Oct 2, 2024
TokisanGames
reviewed
Oct 2, 2024
TokisanGames
reviewed
Oct 2, 2024
TokisanGames
reviewed
Oct 2, 2024
TokisanGames
reviewed
Oct 2, 2024
TokisanGames
reviewed
Oct 2, 2024
TokisanGames
requested changes
Oct 2, 2024
Xtarsia
force-pushed
the
control-map-api_changes
branch
4 times, most recently
from
c362ab7
to
0069d2a
Compare
|
Auto/nav/hole need another adjustment. I added XML. You could fill out the description or at least return values and I'll wrap up anything left. |
TokisanGames
reviewed
Oct 4, 2024
|
Hopefully ready for @TokisanGames to apply that final bit of polish now.. |
TokisanGames
force-pushed
the
control-map-api_changes
branch
from
6313bd9
to
4a319ea
Compare
|
Very good, thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need some feedback about function names, everything tested and working ok.
this method of taking the original control, and masking before or-ing could be added to the util docs page too.
(control & ~(0x1F << 27)) | (base >> 27 & 0x1F)