Implemented XLMRoberta sub-tasks
#5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sweet! |
|
Can you run install and run pre-commit on your files |
| if labels is not None: | ||
| # move labels to correct device to enable model parallelism | ||
| labels = labels.to(logits.device) | ||
| loss_fct = nn.losses.cross_entropy() |
There was a problem hiding this comment.
nn.losses.cross_entropy is a function so it should be loss_fct = nn.losses.cross_entropy
| else: | ||
| loss = loss_fct(logits, labels) | ||
| elif self.config.problem_type == "single_label_classification": | ||
| loss_fct = nn.losses.cross_entropy() |
Used autopep8 before now, would use pre-commit now |
|
Ready to be Merged |
ToluClassics
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Implemented
XLMRobertaForSequenceClassification,XLMRobertaForTokenClassificationand XLMRobertaForQuestionAnswering and provided their corresponding tests. All tests passed.Types of changes
What types of changes does your code introduce?
Put an
xin the boxes that apply