Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update vehicles and weapons for The Contract DLC (MPSECURITY, v2545) #268

Closed
wants to merge 2 commits into from
Closed

Update vehicles and weapons for The Contract DLC (MPSECURITY, v2545) #268

wants to merge 2 commits into from

Conversation

MichaelCoding25
Copy link
Contributor

  • Add new weapons from DLC
  • Add new weapon components from DLC
  • Add missing weapon components from older DLCs
  • Add new vehicles from DLC

@MichaelCoding25
Update vehicles and weapons for The Contract DLC (MPSECURITY, v2545)
6e55712 
- Add new weapons from DLC
- Add new weapon components from DLC
- Add missing weapon components from older DLCs
- Add new vehicles from DLC
@MichaelCoding25 MichaelCoding25 changed the base branch from master to development December 19, 2021 18:09
@MichaelCoding25 MichaelCoding25 marked this pull request as draft December 23, 2021 11:05
@MichaelCoding25
Copy link
Contributor Author

Will test this as soon as FiveM starts supporting 2545

@MichaelCoding25 MichaelCoding25 marked this pull request as ready for review December 28, 2021 19:13
@MichaelCoding25
Copy link
Contributor Author

All has been tested and works well, the only thing is the new MP Stun gun has the exact same name and description as the single-player one, the only difference is the damage it does and the reload time.

@Burnswood
Copy link

All has been tested and works well, the only thing is the new MP Stun gun has the exact same name and description as the single-player one, the only difference is the damage it does and the reload time.

Don't believe this is true, regular stun-gun uses "weapon_stungun" while the MP one uses "weapon_stungun_mp"

Shouldn't conflict.

@MichaelCoding25
Copy link
Contributor Author

All has been tested and works well, the only thing is the new MP Stun gun has the exact same name and description as the single-player one, the only difference is the damage it does and the reload time.

Don't believe this is true, regular stun-gun uses "weapon_stungun" while the MP one uses "weapon_stungun_mp"

Shouldn't conflict.

Correct, they don't conflict but if you look in vmenu they have the exact same name, so you can only know which one you get after you spawn it in

@Burnswood
Copy link

Wouldn't that mean we could just change the name that shows up in the weapon menu to differentiate? Like "Stun Gun 2" or "Stun Gun MP"

@MichaelCoding25 MichaelCoding25 mentioned this pull request Jan 18, 2022
Closed
ghost pushed a commit to ProjectFairnessLabs/PF-vMenu that referenced this pull request Mar 29, 2022
Pull Request Added (The Contract Weapons & Cars, Tuners Vehicle Stanc…
ec81abc 
…e and Tires, etc.)

Added the pull requests from the following:

TomGrobbe#268 (@MichaelCoding25)
TomGrobbe#269 (@AlexR32)
TomGrobbe#273 (@freedy69)
@MichaelCoding25
Copy link
Contributor Author

Closing this PR due to #278.

@MichaelCoding25 MichaelCoding25 deleted the mpsecurity_patch branch August 29, 2022 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MichaelCoding25 @Burnswood