feat: ✨ Add WebSocket html, ascii doc support #855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
linwumingshi
commented
Jul 21, 2024
linwumingshi
commented
- feat: ✨ Add WebSocket html, ascii doc support
- refactor(grpc): 💄 update GrpcApiDoc and related builders for formatting
- Refactor `GrpcApiDoc` model to extend `AbstractRpcApiDoc` and simplify code. - Update `GrpcAsciidocBuilder`, `GrpcHtmlBuilder`, and `GrpcMarkdownBuilder` to work with the updated `GrpcApiDoc` model. - Ensure consistent use of `List<GrpcApiDoc>` across builder classes. - Remove redundant imports and methods in `IRpcDocBuilderTemplate`.- Add new constants and improve existing ones in `DocGlobalConstants`. - Other minor code cleanup for better readability and maintainability. BREAKING CHANGE: This commit changes the `GrpcApiDoc` model which may affect downstream systems that rely on the previous structure of `RpcApiDoc`.
shalousun
approved these changes
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.