Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue If there are enumerations in the query request parameters, the generated request parameter comments will not include 'See'. #945

Conversation

jasonkung22
Copy link
Contributor

Fix issue If there are enumerations in the query request parameters, the generated request parameter comments will not include 'See'.

Copy link

github-actions bot commented Nov 4, 2024

Thanks for your this PR. 🙏
Please check again for your PR changes whether contains any usage configuration change such as Add new configuration, Change default value of configuration.
If so, please add or update documents(markdown type) in docs/ for repository smart-doc-group/smart-doc-group.github.io

In addition, if you have added new features, please provide example code in the repository smart-doc-group/smart-doc-example-cn. This will help other users understand how to use the new features.


感谢您提交的PR。 🙏
请再次查看您的PR内容,确认是否包含任何使用方式 配置参数的变更,如:新增配置参数修改默认配置等操作。
如果是,请确保在提交之前,在仓库smart-doc-group/smart-doc-group.github.io中的docs/目录下添加或更新文档(markdown格式)。

另外,如果您添加了新功能,请在仓库smart-doc-group/smart-doc-example-cn中提供示例代码。这将帮助其他用户了解如何使用新功能。

@linwumingshi linwumingshi self-requested a review November 4, 2024 06:52
Copy link
Collaborator

@linwumingshi linwumingshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the existing static method in com.ly.doc.helper.ParamsBuildHelper#handleEnumComment can be used to complete this modification.

…ers, the generated request parameter comments will not include 'See'.
@jasonkung22 jasonkung22 force-pushed the feature_enum-query-commen branch from 8f9ab74 to 41e094a Compare November 4, 2024 07:21
@linwumingshi linwumingshi merged commit 5359635 into TongchengOpenSource:master Nov 4, 2024
11 checks passed
@linwumingshi
Copy link
Collaborator

close #939

@linwumingshi linwumingshi added this to the 3.0.9 milestone Nov 4, 2024
@linwumingshi linwumingshi added the bug Something isn't working label Nov 4, 2024
@jasonkung22 jasonkung22 deleted the feature_enum-query-commen branch November 6, 2024 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants