Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added types #2

Merged
merged 2 commits into from
Nov 15, 2022
Merged

added types #2

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c63f7bd
added types
Rebal17 Nov 1, 2022
1fd98ad
Merge branch 'master' of https://github.com/Tonomy-Foundation/did-res…
Rebal17 Nov 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions src/resolver.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ export interface VerificationMethod {
// TODO add other properties of VerifiableConditions: threshold, conditionThreshold, conditionAnd, conditionOr
}

interface ConditionWeightedThreshold {
export interface ConditionWeightedThreshold {
condition: {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

condition would be better if this would be of type VerificationMethod

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can do this in a future PR though

id: string
controller: string
Expand All @@ -179,7 +179,6 @@ interface ConditionWeightedThreshold {
}
weight: number
}

/**
* URI params resulting from parsing a DID URI
*/
Expand Down