Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SSLParameters for WebSocketClient #1000

Merged
merged 4 commits into from
Apr 23, 2020
Merged

SSLParameters for WebSocketClient #1000

merged 4 commits into from
Apr 23, 2020

Conversation

marci4
Copy link
Collaborator

@marci4 marci4 commented Apr 19, 2020 •
edited
Loading

Description

This feature enables the access to the SSLParameters and enables hostname validation by default

Related Issue

Fixes #997

Motivation and Context

Security (fixes missing hostname validation)

How Has This Been Tested?

Tests were created

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@marci4 marci4 requested a review from PhilipRoman April 19, 2020 15:23
@marci4 marci4 added this to the Release 1.5.0 milestone Apr 19, 2020
@PhilipRoman PhilipRoman mentioned this pull request Apr 22, 2020
Merged
8 tasks
@marci4 marci4 merged commit cab3fda into TooTallNate:master Apr 23, 2020
@marci4 marci4 deleted the Issue997 branch April 23, 2020 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhilipRoman PhilipRoman PhilipRoman approved these changes

Assignees
No one assigned
Labels
Client New Feature wss
Projects
None yet
Milestone
Release 1.5.0
Development

Successfully merging this pull request may close these issues.

Access to SSLParameters used by the WebSocketClient
2 participants
@marci4 @PhilipRoman