Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve code quality #1072

Merged
merged 2 commits into from
Jan 7, 2021
Merged

Improve code quality #1072

merged 2 commits into from
Jan 7, 2021

Conversation

marci4
Copy link
Collaborator

@marci4 marci4 commented Sep 20, 2020

Description

This PR fixes issues found by SonarQube

Motivation and Context

Ongoing move to improve code quality

How Has This Been Tested?

Automatic tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@marci4 marci4 added this to the Release 1.5.2 milestone Sep 20, 2020
@marci4
Code Quality
08be869 
Reduce complexity
Fix broken test
@marci4 marci4 marked this pull request as ready for review September 26, 2020 16:17
@marci4 marci4 merged commit 0f0c9a9 into TooTallNate:master Jan 7, 2021
@marci4 marci4 deleted the ImproveCodeQuality branch January 7, 2021 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Documentation Refactor
Projects
None yet
Milestone
Release 1.5.2
Development

Successfully merging this pull request may close these issues.
1 participant
@marci4