Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add true WSS support to WebSocketClient #510

Merged
merged 1 commit into from
Jun 21, 2017

Conversation

ignaciomolina
Copy link
Contributor

Added internal support for ssl when using wss schema.

@marci4
Copy link
Collaborator

marci4 commented Jun 21, 2017

Hello @ignaciomolina,
thx for your pull request!

Going to merch it.
Greetings
marci4

@marci4 marci4 merged commit 5e01965 into TooTallNate:master Jun 21, 2017
@marci4 marci4 mentioned this pull request Jun 21, 2017
@ignaciomolina
Copy link
Contributor Author

Do you know if you already planned the next release date?
This is to know when I could use the upstream version instead of my own

@marci4
Copy link
Collaborator

marci4 commented Jun 22, 2017

I do have university exams over the next 4 weeks so not really soon.

Apart from this. You can use this also with the current version

SSLContext sslContext = SSLContext.getInstance( "TLS" );
sslContext.init( null, null, null ); // will use java's default key and trust store which is sufficient unless you deal with self-signed certificates
SSLSocketFactory factory = sslContext.getSocketFactory();// (SSLSocketFactory) SSLSocketFactory.getDefault();
chatclient.setSocket( factory.createSocket() );

Greetings
marci4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants