Pass on exit code in WebSocketClient close function - fixes bug #827 #846
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the class WebSocketClient in the close function, I passed the "code" argument on to the "close" call of the WebSocketImpl "engine".
Related Issue
This bug was mentioned in #827.
Motivation and Context
This fixes a bug where the originally supplied CloseFrame code was ignored and the CloseFrame.NORMAL code was passed on instead.
How Has This Been Tested?
All the existing unit tests passed. I manually looked at the implementations of the close function and at the usages of the code argument and came to the conclusion that this change shouldn't have introduced a new issue.
This admittedly small amount of testing should suffice since this is only a minor bug fix that utilises existing functions.
Types of changes
Checklist: