Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unused/unrelated imports (including deprecated CORBA) #848

Merged
merged 1 commit into from
Feb 4, 2019
Merged

Removed unused/unrelated imports (including deprecated CORBA) #848

merged 1 commit into from
Feb 4, 2019

Conversation

PhilipRoman
Copy link
Collaborator

@PhilipRoman PhilipRoman commented Jan 29, 2019

Description

Removed a few imports from InvalidEncodingExceptionTest.

One of those imports was org.omg.CORBA.DynAnyPackage.Invalid which comes from a deprecated package and prevents test compilation on JDK 11 (see relevant JEP)

Related Issue

Motivation and Context

Fixes test compilation on platforms where org.omg.CORBA.DynAnyPackage.Invalid is unavailable, such as JDK 11 and later

How Has This Been Tested?

No functionality has been modified, the imports were not used (I'm assuming they're a result of an accidental IDE auto-import)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@marci4 marci4 added this to the Release 1.4.0 milestone Jan 29, 2019
@marci4 marci4 merged commit 744348e into TooTallNate:master Feb 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants