Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outdated 'wrapper' task from build.gradle (#907) #908

Merged
merged 1 commit into from
Jun 16, 2019

Conversation

PhilipRoman
Copy link
Collaborator

Fixes #907

Description

The issue and solution is described here: https://stackoverflow.com/questions/53709282/cannot-add-task-wrapper-as-a-task-with-that-name-already-exists

git blame shows that build.gradle was last modified in 2013: c2e7493 and therefore uses a very old version of Gradle (1.4). Since Gradle wrapper isn't currently tracked in the git repo (maybe it should be?), I simply deleted the whole 'wrapper' block.

Related Issue

#907

Motivation and Context

The current build.gradle file is outdated and produces errors when used with modern Gradle versions.

How Has This Been Tested?

Building with Gradle 5+ now works as expected.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@PhilipRoman PhilipRoman changed the title Remove 'wrapper' task from build.gradle (#907) Remove outdated 'wrapper' task from build.gradle (#907) Jun 13, 2019
@marci4 marci4 added this to the Release 1.4.1 milestone Jun 14, 2019
@marci4 marci4 self-requested a review June 14, 2019 06:49
@marci4 marci4 merged commit 4c0a555 into master Jun 16, 2019
@marci4 marci4 deleted the gradle-build-fix branch June 16, 2019 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

build fails with Gradle 5+
2 participants