Fix prototype pollution #114 #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the basic attack for CVE-2022-22912. Issue #114.
This PR introduce a new invariant where
<key>tags can't have the__proto__value avoiding prototype pollution attacks. While testing I noticed both__proto__string and variations with backslash such as_\_proto_\_can trigger the vulnerability but both attacks are stopped by this fix.I went through the codebase and the only vector of attack I found for this vulnerability was through the
dictandkeybut would appreciate the maintainers advice in case I have missed something.