npm audit fix --force (solves 13 critical vulnerabilities) #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current npm audit ONLY affect devDependencies. so it's imho safe to go! |
|
I'd rather solve this by removing the in-browser tests #126 |
|
There should be ways to test this library in the browser in ghci, but i have never done that. i'll keep that one for you :) thanks for the prompt responses and merges! i'm going to remove my forks and use the main repository. |
The existing project is set up to use sauce labs, and it technically should still work. I just don't think this really matters much any more. node tests are sufficient imo. |
my pleasure, thanks for crushing through these issues like a boss. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.