-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Please create a 2.x branch and pull in this commit and publish #84
Comments
Update Oct 22/2019This should no longer be an issue, so do not follow the below steps. If you're coming from the future, this will likely not solve your problem. See #84 (comment) around the resolution. 2.2.3 of https-proxy-agent has been released. If you have followed the below, remove the workaround with:
Original fixIn case anyone else's deploys are stuck on this - https://www.npmjs.com/package/npm-force-resolutions may help you out while this is addressed, or while your dependencies update their dependencies (which may need to update their dependencies...)
This will force your dependencies to update to 3.0.1 as of right now. The bump from 2.2.2 to 3.0.0 can be read about here: https://github.com/TooTallNate/node-https-proxy-agent/releases/tag/3.0.0 Summary of major changes: So if you're not running those versions of node, you should be fine. Run your tests, and ensure your application is running fine manually. Remember to get rid of this workaround as soon as either
|
Thanks, I can confirm that this worked. However, the message came back when I removed a package that is dependent of https-proxy-agent In that case, I ran the commands again to fix it rm -r node_modules
npx npm-force-resolutions
npm install |
With above steps, it only temporarily goes away. npm i gets the issue back. |
@TooTallNate would you be able to publish/merge @AaronFriel's patch? |
This pins https-proxy-agent to a version >3.0.0 for now. This can be removed when 1) either the security fix is backported to https-proxy-agent 2.x or 2) all packages we depend on have updated their dependencies to use https-proxy-agent > 3.0.0. TooTallNate/proxy-agents#84
Please do this. |
I see that v2.2.3 with the same fix was released couple of hours ago. Is anybody aware about the right way to update the advisory so that |
Someone should contact GitHub to speed things up. |
I just pinged npm security team via email, not sure what's the right way to fix GitHub audit. |
The npm advisory was just updated to mention 2.2.3 as not vulnerable - https://www.npmjs.com/advisories/1184/versions |
Done in v2.2.3. |
This will unblock many, many people who are unable to resolve
npm audit
errors in their CI/CD system.AaronFriel@25d3006
The text was updated successfully, but these errors were encountered: