Added tests for API.ts #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for topgg-node-sdk-docs ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
Anonymous4078
approved these changes
May 14, 2023
jpbberry
approved these changes
Jul 7, 2023
|
Thanks for the contribution @XkijuX ! |
This was referenced Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added tests for API.ts using undici internal mock-interceptor. All requests to the domain https://top.gg are captured and handled accordingly through this. Everything else is currently blocked. The data used to respond to the API is located in
mocks/data.tsand all endpoints are inendpoints.ts. In this file specific tests for further validations on the API route can be added.During testing, I found some inconsistencies in the code such as variable testing before making the requests. I believe these should be fixed in another pull request.