chore(sdk): remove retrofit and okhttp #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbergstroem
reviewed
Jun 26, 2024
jbergstroem
reviewed
Jun 26, 2024
jbergstroem
reviewed
Jun 26, 2024
| import com.topsort.analytics.model.ImpressionEvent | ||
| import com.topsort.analytics.model.PurchaseEvent | ||
|
|
||
| private const val apiUrl = "https://api.topsort.com/v1/events" |
There was a problem hiding this comment.
Can the hostname be a project wide constant and potentially overridable? Lets say we wanna point it at a staging or test environment
There was a problem hiding this comment.
I'll address in future PRs when we get a better testing setup
There was a problem hiding this comment.
This is not about tests though
jbergstroem
reviewed
Jun 26, 2024
TopsortAnalytics/src/test/java/com/topsort/analytics/TopsortAnalyticsHttpServiceTest.kt
Outdated
Show resolved
Hide resolved
PabloReszczynski
approved these changes
Jun 27, 2024
jbergstroem
reviewed
Jul 3, 2024
| internal fun HttpURLConnection.createPostConnection(): Connection { | ||
| val encoding = getRequestProperty("Content-Encoding") ?: "" | ||
| val outputStream: OutputStream = | ||
| if (encoding.contains("gzip")) { |
There was a problem hiding this comment.
do we additionally wanna support deflate, br here? can the http library help us in any way?
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test Bearer token AuthorizationAdd mocked testWill be in future PRs
Closes: https://topsort.atlassian.net/browse/API-796