Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed broken cfg.debug calls in chat #839

Closed
wants to merge 1 commit into from
Closed

Fixed broken cfg.debug calls in chat #839

wants to merge 1 commit into from

Conversation

javierbq
Copy link

@javierbq javierbq commented Apr 11, 2023

Background

Changes

Documentation

Test Plan

PR Quality Checklist

  • My pull request is atomic and focuses on a single change.
  • I have thouroughly tested my changes with multiple different prompts.
  • I have considered potential risks and mitigations for my changes.
  • I have documented my changes clearly and comprehensively.
  • I have not snuck in any "extra" small tweaks changes

@thegalluzz
Copy link

If I'm not mistaken there is the same bug in /scripts/json_parser.py

Copy link

@Bharateshwar Bharateshwar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/scripts/json_parser.py needs the change too.

Copy link

@VincentRoma VincentRoma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@drikusroor drikusroor mentioned this pull request Apr 11, 2023
5 tasks
@100xlongx
Copy link

json_parser.py line 94

@richbeales
Copy link
Contributor

A duplicate of this has already been merged

@richbeales richbeales closed this Apr 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants