-
Notifications
You must be signed in to change notification settings - Fork 44.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unit tests workflow #865
Merged
richbeales
merged 16 commits into
Significant-Gravitas:master
from
drikusroor:add-unit-tests-workflow
Apr 12, 2023
Merged
Add unit tests workflow #865
richbeales
merged 16 commits into
Significant-Gravitas:master
from
drikusroor:add-unit-tests-workflow
Apr 12, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richbeales
previously approved these changes
Apr 12, 2023
Think we should add flake8 too |
Do you want me to do that in this PR or in a separate PR after this one has been merged? |
If you're happy to, it'd be great to add it in a separate PR. |
drikusroor
force-pushed
the
add-unit-tests-workflow
branch
from
April 12, 2023 06:53
7c55934
to
a5ca5ee
Compare
Let's go :) |
drikusroor
force-pushed
the
add-unit-tests-workflow
branch
from
April 12, 2023 08:16
a5ca5ee
to
5265d81
Compare
@Torantulino would be good to get your eyes over this, and get this and 923 merged if you're happy? |
richbeales
previously approved these changes
Apr 12, 2023
richbeales
approved these changes
Apr 12, 2023
sindlinger
pushed a commit
to Orgsindlinger/Auto-GPT-WebUI
that referenced
this pull request
Sep 25, 2024
…tests-workflow Add unit tests workflow
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
The last days we have seen quite some instability after some PRs had been merged, related to config properties, json parsing, infinite loops. This PR doesn't necessarily fix those issues but unit tests run in a workflow and is an attempt to try to set a first baseline for protecting the quality and desired functionality of the code. Additionally, it allows other developers to add new or change existing unit tests in a relatively straight-forward way.
Changes
master
branch and for every PR targeted towards themaster
branch.json_parser
unit tests.Config
class.cfg.debug
issue that was already reported earlier. These changes will probably "disappear" from the changed files once someone else's PR fixes it. (See also here, here, here, and here 😅 )Documentation
README.md
README.md
Test Plan
The test plan is to create this PR and see if:
README.md
PR Quality Checklist
cfg.debug
issue was "snuck in". Please let me know if you want me to remove it.