Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix upload-queued jobs being terminated suddenly #945

Merged
merged 1 commit into from
Jun 29, 2023

Conversation

GianniCarlo
Copy link
Collaborator

Bugfix

  • When uploading the contents of a folder, and the folder is renamed, the process of uploading is interrupted

Related tasks

#942

Approach

  • Remove check if it's a book when creating a hard link, this also works for folders, and per the docs, it creates a hard link for the contents as well

Things to be aware of / Things to focus on

  • The hard link is what lets us reference the file, and the user is free to move it anywhere they want in the library, we'll still be able to find the contents and upload it when the queued task runs. There's still one scenario (given that we queue the tasks and run them async) where the hard link could fail to create, and the user moved the file from the original place, and we won't find the contents of that particular file. We have to work on a way to let the user know that one of the items is not uploaded, and only the metadata is up

@GianniCarlo GianniCarlo self-assigned this Jun 29, 2023
@GianniCarlo GianniCarlo merged commit a8990e8 into develop Jun 29, 2023
@GianniCarlo GianniCarlo deleted the 942-hardlinks-rename branch June 29, 2023 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant