Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add proper VoiceOver support for profile screens #952

Merged
merged 2 commits into from
Jul 4, 2023
Merged

Add proper VoiceOver support for profile screens #952

merged 2 commits into from
Jul 4, 2023

Conversation

GianniCarlo
Copy link
Collaborator

Purpose

The new screens introduced for v5.0.0 are not very accessible:

  • Profile screen
  • Login screen
  • Account screen
  • Complete account screen

Related tasks

#941

Approach

  • Rework entire CompleteAccountViewController into a SwiftUI view
    • If VoiceOver is active, do not present the screen to halfway of the screen, as it will try to focus on elements from the screen on the background
  • For all the other screens, it was more of combining elements, so they are read as a unit, and disabling others like icons

Things to be aware of / Things to focus on

  • SwiftUI does not have proper VoiceOver-focus controls APIs for iOS 14

Screenshots

RPReplay_Final1688476478.MP4
RPReplay_Final1688476535.MP4

@GianniCarlo GianniCarlo self-assigned this Jul 4, 2023
@GianniCarlo GianniCarlo merged commit 1ac1547 into develop Jul 4, 2023
@GianniCarlo GianniCarlo deleted the fix-voiceover-profile branch July 4, 2023 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@GianniCarlo GianniCarlo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@GianniCarlo