Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix a compile error in a code example #172

Merged
merged 1 commit into from
Oct 10, 2021
Merged

fix a compile error in a code example #172

merged 1 commit into from
Oct 10, 2021

Conversation

estshorter
Copy link
Contributor

not keyword is not defined in C++ and the code example causes a compile error.
This PR fixes the issue above.

@ToruNiina
Copy link
Owner

Actually, not is a keyword in C++ and should be available without doing anything. (in C, it is not a keyword but a valid identifier.) MSVC does not define it because of some reasons, but it, strictly speaking, violates C++ standard.

But anyway, many people uses MSVC and example should be compatible with as many environment as possible, so okay I will merge this.

@estshorter
Copy link
Contributor Author

I didn't know the alternative operators.
Thank you for letting me know!

@ToruNiina ToruNiina merged commit f2f2b44 into ToruNiina:master Oct 10, 2021
@estshorter estshorter deleted the fix_readme branch October 17, 2021 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants