Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue #231 #233

Merged
merged 4 commits into from
Jan 4, 2024
Merged

fix issue #231 #233

merged 4 commits into from
Jan 4, 2024

Conversation

Esonhugh
Copy link
Contributor

@Esonhugh Esonhugh commented Dec 27, 2023

Link issue #231

It's possible a fix for #231 . But I still have no idea why _GNU_SOURCE is defined in something like Havoc.

@ToruNiina
Copy link
Owner

It seems that github actions does not support runner named macos-13-arm64. Although there is a doc about macos-13-arm64 (https://github.com/actions/runner-images/tree/main/images/macos), but the job does not run. I searched other repositories that tries to run it by https://github.com/search?q=macos-13-arm64&type=code. I looked 2 or 3 of those, but none of them are running.

And it seems to have not been supported yet, I think we can just comment out macos-13-arm64 section for now.
https://docs.github.com/ja/actions/using-github-hosted-runners/about-github-hosted-runners/about-github-hosted-runners#supported-runners-and-hardware-resources

@Esonhugh
Copy link
Contributor Author

Esonhugh commented Jan 4, 2024

It seems that github actions does not support runner named macos-13-arm64. Although there is a doc about macos-13-arm64 (https://github.com/actions/runner-images/tree/main/images/macos), but the job does not run. I searched other repositories that tries to run it by https://github.com/search?q=macos-13-arm64&type=code. I looked 2 or 3 of those, but none of them are running.

And it seems to have not been supported yet, I think we can just comment out macos-13-arm64 section for now. https://docs.github.com/ja/actions/using-github-hosted-runners/about-github-hosted-runners/about-github-hosted-runners#supported-runners-and-hardware-resources

It looks same on my side. But What's the ClusterFuzzlite. It works on my repo, but failed in PR. : ?

@ToruNiina
Copy link
Owner

ToruNiina commented Jan 4, 2024

But What's the ClusterFuzzlite.

I think that error is not caused by this change.
I have no idea why it fails here instead of the PullReq of ClusterFuzzlite, but I think I have just fixed it in #234 .

The input contains over 2000 [ and it causes stack overflow on ci docker env because of recursive call of parse_value and parse_array. It successfully returns an error message in my local env, but somehow fails in docker running on ci, maybe because of some difference in flags or something. I added a parameter to detect deep nest of array or inline table and now it can throw an error instead of stack overflow.

Hopefully, it works when we re-run ci with the updated branch.

@ToruNiina
Copy link
Owner

Okay it works with macos-13. merging.

@ToruNiina ToruNiina merged commit 1bb5284 into ToruNiina:master Jan 4, 2024
152 checks passed
@Esonhugh
Copy link
Contributor Author

Esonhugh commented Jan 5, 2024

Great

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants